humanmade / humanmade/Mercator-REST-API

Add make_primary endpoint

Aperta
#3 3 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
PHP
Stelle
2
Fork
2
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

After https://github.com/humanmade/Mercator/pull/80 has been merged it might be good to add a route to call that method on a mapping

**Approach 1**

`mappings/123/make_primary`

It's a little tricky to determine what this should look like from a REST perspective though. Under the hood there's a `DELETE` (remove current mapping) and a `POST` (create mapping from previous primary domain) essentially with `wp_options` and `wp_blogs` table updates thrown in too.

I'm thinking `PUT` or `PATCH` makes the most sense. We're updating/acting upon the current mapping and `PATCH` doesn't require the object be returned.

**Approach 2**

Alternatively is it worth adding a `mappings/primary` endpoint? Or just `primary`. Feels that's something to handle in a multisite API but could be argued for adding here if it's a way of calling `make_primary()`. Would allow for more self contained UI to be built off it without other dependencies too as you need the primary domain info.

We could use the following routes as the means of getting & setting an alias to be the primary, say:
- `/mappings/primary` GET - `get_site()` result
- `/mappings/primary` POST - takes a mapping ID and calls `Mapping::make_primary()`

@rmccue thoughts?

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.