huggingface / huggingface/diffusers

FlaxStableDiffusionImg2ImgPipeline should delete prepare_inputs and provide prepare_text_inputs and prepare_image_inputs

Aperta
#9,371 4 commenti 0 reazioni 0 assegnatari Vedi su GitHub
stale
Lingua principale
Python
Stelle
34.5k
Fork
7.3k
Merge medio
3g 3h
PR unite (30g)
91

Descrizione

**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...].
in https://github.com/huggingface/diffusers/blob/main/src/diffusers/pipelines/stable_diffusion/pipeline_flax_stable_diffusion_img2img.py#L170
prepare_inputs(self, prompt: Union[str, List[str]], image: Union[Image.Image, List[Image.Image]]) accept both prompt and image
But there are prompt_ids and neg_prompt_ids in https://github.com/huggingface/diffusers/blob/main/src/diffusers/pipelines/stable_diffusion/pipeline_flax_stable_diffusion_img2img.py#L338 which prompt (positive or negative) I should put to prepare_inputs?

**Describe the solution you'd like.**
A clear and concise description of what you want to happen.
like https://github.com/huggingface/diffusers/blob/main/src/diffusers/pipelines/controlnet/pipeline_flax_controlnet.py#L180 and https://github.com/huggingface/diffusers/blob/main/src/diffusers/pipelines/controlnet/pipeline_flax_controlnet.py#L194
delete prepare_inputs and provide prepare_text_inputs and prepare_image_inputs

**Describe alternatives you've considered.**
A clear and concise description of any alternative solutions or features you've considered.

**Additional context.**
Add any other context or screenshots about the feature request here.

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Start in src/diffusers/pipelines/stable_diffusion/pipeline_flax_stable_diffusion_img2img.py, especially prepare_inputs and the prompt_ids and neg_prompt_ids usage around the cited lines. Compare the separate prepare_text_inputs and prepare_image_inputs methods in src/diffusers/pipelines/controlnet/pipeline_flax_controlnet.py. Done means the img2img pipeline no longer exposes prepare_inputs and provides the two separate preparation methods without ambiguity about positive and negative prompts.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
python
Ambito
machine-learning
Tipo di issue
Funzionalità
Difficoltà
2/5
Tempo stimato
1-3 ore
Stato di attività
Ferma
Chiarezza
Specificata chiaramente
Idoneità per principianti
38/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.