huggingface / huggingface/diffusers

Support out_dim argument for Attention block

Abierto
#7,877 4 comentarios 0 reacciones 0 asignados Ver en GitHub
stale
Lenguaje dominante
Python
Estrellas
34.5k
Forks
7.3k
Merge medio
3 d 3 h
PR fusionados (30 d)
91

Descripción

**Is your feature request related to a problem? Please describe.**
When i feed the `out_dim` argument in `__init__` in [Attention block](https://github.com/huggingface/diffusers/blob/b69fd990ad8026f21893499ab396d969b62bb8cc/src/diffusers/models/attention_processor.py#L114) it will raise the shape error, because the `query_dim != out_dim`. In this case, the following code try to keep the given channel of `hidden_states`.
> https://github.com/huggingface/diffusers/blob/b69fd990ad8026f21893499ab396d969b62bb8cc/src/diffusers/models/attention_processor.py#L1393
But it should change the channel as the output of `hidden_states = attn.to_out[0](hidden_states)`.

**Describe the solution you'd like.**
I suggest the change of code base : https://github.com/huggingface/diffusers/blob/b69fd990ad8026f21893499ab396d969b62bb8cc/src/diffusers/models/attention_processor.py#L1393
to `hidden_states = hidden_states.transpose(-1, -2).reshape(batch_size, -1, height, width)`, then it will respect the channel of `hidden_states`.
Maybe I will make a PR later.

**Describe alternatives you've considered.**
None.

**Additional context.**
None.

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Start in src/diffusers/models/attention_processor.py at the Attention block and the referenced processing code around line 1393. Reproduce the shape error with query_dim != out_dim, then verify that the attention output preserves the requested channel dimension and that existing attention behavior remains unchanged.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
python, pytorch
Área
machine-learning
Tipo de issue
Nueva funcionalidad
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Estancado
Claridad
Bien especificado
Aptitud para principiantes
48/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.