huggingface / huggingface/diffusers

PixArtAlphaPipeline does not handle negative_prompt list correctly

Aperta
#7,759 8 commenti 0 reazioni 0 assegnatari Vedi su GitHub
bug stale
Lingua principale
Python
Stelle
34.5k
Fork
7.3k
Merge medio
3g 3h
PR unite (30g)
91

Descrizione

### Describe the bug

Passing negative_prompt as list to PixArtAlphaPipeline will eventually cause a "list object has no attribute lower" error.

The encode_prompt function documentation shows that it can be a list as well:
https://github.com/huggingface/diffusers/blob/7404f1e9dcdac286caf6ca3cfa43b294f61583bf/src/diffusers/pipelines/pixart_alpha/pipeline_pixart_alpha.py#L308

However the function type hints restrict it to a str instead:
https://github.com/huggingface/diffusers/blob/7404f1e9dcdac286caf6ca3cfa43b294f61583bf/src/diffusers/pipelines/pixart_alpha/pipeline_pixart_alpha.py#L291

These restrictions are completely arbitrary, since
a) prompt is correctly handled for the same case,
b) negative_prompt is only used in one place and there it just gets converted to a list anyway:

https://github.com/huggingface/diffusers/blob/7404f1e9dcdac286caf6ca3cfa43b294f61583bf/src/diffusers/pipelines/pixart_alpha/pipeline_pixart_alpha.py#L392

### Reproduction

Call Pixart-Sigma with negative_prompt as list instead of a single string.

### Logs
(sorry for images)

![image](https://github.com/huggingface/diffusers/assets/1809172/b7916b50-09f1-4b1d-96e5-5b3841dff53b)
![image](https://github.com/huggingface/diffusers/assets/1809172/0b4e85bd-4fc3-4fdb-afd1-c16c79f41a6a)

### System Info

Windows 11
PyTorch 2.2.2 with CUDA support
Diffusers 0.28.0.dev0 @ https://github.com/huggingface/diffusers/commit/7404f1e9dcdac286caf6ca3cfa43b294f61583bf

### Who can help?

@DN6 @sayakpaul @lawrence-cj

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Start in src/diffusers/pipelines/pixart_alpha/pipeline_pixart_alpha.py, at encode_prompt and the negative_prompt handling around line 392. Reproduce PixArt-Sigma with negative_prompt as a list, then verify that the pipeline accepts the list without the reported lower error and handles it consistently with prompt.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
python, pytorch
Ambito
machine-learning
Tipo di issue
Bug
Difficoltà
2/5
Tempo stimato
1-3 ore
Stato di attività
Ferma
Chiarezza
Specificata chiaramente
Idoneità per principianti
52/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.