huggingface / huggingface/diffusers
UNet3DConditionModel does not use class conditioning
- Lingua principale
- Python
- Stelle
- 34.5k
- Fork
- 7.3k
- Merge medio
- 3g 3h
- PR unite (30g)
- 91
Descrizione
### Describe the bug
Hello guys,
I found a small inconsistency. In `UNet3DConditionModel` forward method, `class_labels` is [defined](https://github.com/huggingface/diffusers/blob/6fedbd850a282ef21009f99a394f619ed7420137/src/diffusers/models/unets/unet_3d_condition.py#L540C13-L540C25) but is never used after that.
This is different from its twin model `UNet2DConditionModel`, where it is [used](https://github.com/huggingface/diffusers/blob/6fedbd850a282ef21009f99a394f619ed7420137/src/diffusers/models/unets/unet_2d_condition.py#L992) to get an embedding which is later used by the model.
Cheers.
### Reproduction
Does not apply.
### Logs
_No response_
### System Info
Does not apply.
### Who can help?
_No response_
Guida per i contributori
Apri la guida per i contributori
Direzione di ricerca
Start in src/diffusers/models/unets/unet_3d_condition.py at the UNet3DConditionModel forward method and compare its class_labels handling with the linked UNet2DConditionModel implementation. Trace how the class embedding is obtained and consumed in the 2D model. Done means class conditioning is handled consistently in the 3D model and the relevant behavior is covered by the project's existing model tests.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- python, pytorch
- Ambito
- machine-learning
- Tipo di issue
- Bug
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Stato di attività
- Ferma
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 45/100