huggingface / huggingface/diffusers

Any chance class members like self._interrupt could be defined in __init__ across pipelines?

Aperta
#11,002 13 commenti 0 reazioni 0 assegnatari Vedi su GitHub
bug contributions-welcome help wanted stale
Lingua principale
Python
Stelle
34.5k
Fork
7.3k
Merge medio
3g 3h
PR unite (30g)
91

Descrizione

### Describe the bug

I think there is no benefit to late initializing here and it puts a burden on the library user that could be easily avoided. Also leads to some confusion as it is uncommon, code inspection flags this. Let me know if I'm missing something.

### Reproduction

```
class WanImageToVideoPipeline:
def __init__(self):
pass

def __call__(self, *args, **kwargs):
self._interrupt = False
return 23

@property
def interrupt(self):
return self._interrupt

pipe = WanImageToVideoPipeline()

def on_async_user_abort_call_me_any_time():
# check if already interrupted but mid step
print(pipe.interrupt)

on_async_user_abort_call_me_any_time()
```

### Logs

```shell
AttributeError: 'WanImageToVideoPipeline' object has no attribute '_interrupt'. Did you mean: 'interrupt'?
```

### System Info

Diffusers 0.33.0.dev0, Linux, Python 3.10

### Who can help?

@yiyixuxu @DN6

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Start by locating WanImageToVideoPipeline and comparing its __init__, __call__, and interrupt property with the other pipeline classes mentioned by the issue. Determine the affected pipelines and verify that interrupt can be checked immediately after construction; done means the relevant members are consistently available without requiring a prior call.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
python
Ambito
machine-learning
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Attiva
Chiarezza
Abbastanza chiara
Idoneità per principianti
52/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.