hjwp / hjwp/Book-TDD-Web-Dev-Python
ch11l032 - Typo in the test / issue with wait_for + truthiness
- Langage dominant
- Python
- Étoiles
- 514
- Forks
- 175
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
In `ch11l032`, this is introduced, to test the HTML5 validation:
```python
self.wait_for(lambda: self.browser.find_elements_by_css_selector(
'#id_text:invalid'
))
```
However, it isn't testing anything.
Because we are using `find_elementS_by_css_selector(...)` if the element is not found an empty list will be returned and no exception will be raised. Therefore our `wait_for` immediately returns after the first try and we didn't test anything (try making it fail on purpose by looking for a different id, it won't fail).
To fix that, the solution is simple, remove the `S`. That way it'll either find that one element, or raise a `NoSuchElementException`, which is a `WebDriverException`, so our `wait_for` works as expected 🙂
Guide de contribution
Aucun guide de contribution indexé pour ce dépôt
Piste de recherche
Find ch11l032 in the chapter's tests and inspect the wait_for call that uses find_elements_by_css_selector. Change the selector lookup to the singular form, then run the relevant ch11l032 test and verify that a missing invalid element causes the wait to fail rather than returning immediately.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- python
- Domaine
- testing
- Type d'issue
- Bug
- Difficulté
- 1/5
- Temps estimé
- Moins d'une heure
- Activité
- À l'abandon
- Clarté
- Clairement spécifiée
- Accessibilité débutants
- 45/100