hbb20 / hbb20/CountryCodePickerProject

Text color for dark mode

Open
#430 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
1.5k
Forks
509
PR merge metrics
No merged PRs in 30d

Description

Dear all,

Currently code picker text and dialog text reffers to colors:
@android:color/black, @android:color/secondary_text_light
That appears wrong in dark mode.

![image](https://user-images.githubusercontent.com/10271420/89180323-3b9c4b80-d59a-11ea-9174-9342f2844759.png)

---------------------------
setContentColor() could be used, but it require some tricks to determine current theme mode.

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect the Android code picker and dialog rendering that use @android:color/black and @android:color/secondary_text_light; first reproduce the reported dark-mode appearance and trace the setContentColor path. Done means code-picker and dialog text remain readable with appropriate colors in dark mode, with behavior checked in both theme modes.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.