haskell / haskell/vscode-haskell

haskell.manageHLS = "PATH" ignored on initial startup

Ouverte
#1,332 2 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
type: bug
Langage dominant
TypeScript
Étoiles
597
Forks
98
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

### Your environment

MacOS

### Steps to reproduce

run vscode with
```
code --user-data-dir {empty_dir} --extensions-dir {empty_dir} .
```
with devcontainer.json having
```
"settings": {
"haskell.manageHLS": "PATH",
```

### Expected behaviour

The "How do you want the extension to manage/discover HLS and the relevant toolchain?" popup window should not appear.

### Actual behaviour

The popup window will appear.

### Include debug information

According to:
https://github.com/haskell/vscode-haskell/blob/3a8d51f0b15b0a49e98ce47a7786e4bf71c6fbbc/src/hlsBinaries.ts#L350

```
async function promptUserForManagingHls(context: ExtensionContext, manageHlsSetting: ManageHLS): Promise {
if (manageHlsSetting !== 'GHCup' && (!context.globalState.get('pluginInitialized') as boolean | null)) {
const promptMessage = `How do you want the extension to manage/discover HLS and the relevant toolchain?

Choose "Automatically" if you're in doubt.
`;
```
I have set manageHlsSetting to "PATH" in the devcontainer.json.
It does not equal to "GHCup", so the first part of the condition is true.
The plugin has not been initialized, so the second part of the condition is also true.
Hence the popup window will appear.

Workaround:
Set manageHlsSetting to "GHCup" in the devcontainer.json,
and set all the keys in "haskell.toolchain" to null to mimic the "PATH" behavior.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.