haskell / haskell/vscode-haskell

Documentation/Source links to wrong URI when opened in Hackage (with ghc >= 9.8.4).

Ouverte
#1,303 3 commentaires 1 réaction 0 personnes assignées Voir sur GitHub
type: bug
Langage dominant
TypeScript
Étoiles
597
Forks
98
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

This is the same problem as https://github.com/haskell/haskell-language-server/issues/4579. I believe the "bug" is in the vscode extension so I opened this. Also, I can reproduce on linux with recent enough ghc versions, i.e starting with ghc-9.8.4.

The crux is that HLS is sending the URIs for the locally stored docs, e.g.
```
[Documentation](file:///home/vscode/.ghcup/ghc/9.8.4/share/doc/ghc-9.8.4/html/libraries/base-4.19.2.0-9fbd/System-IO.html#v:putStrLn)

[Source](file:///home/vscode/.ghcup/ghc/9.8.4/share/doc/ghc-9.8.4/html/libraries/base-4.19.2.0-9fbd/src/System.IO.html#putStrLn)
```
and `vscode-haskell` does some mangling to point them to Hackage instead. Since ghc-9.8.4 the mangling is insufficient, as it keeps the `-9fbd` suffix in the URI, which is not correct.

The package directories are named `$pkg_name-$pkg_ver-$hex` where $hex is 4 hex digits. We want to drop the `-$hex` suffix, and since `$pkg_ver` cannot contain `-` it's actually unambiguous.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.