haskell / haskell/haskell-language-server

Incorrect highlighting in hover in VS Code

Open
#389 3 comments 0 reactions 0 assignees View on GitHub
component: ghcide type: bug
Dominant language
Haskell
Stars
3k
Forks
455
Avg merge
2d 19h
Merged PRs (30d)
11

Description

I have noticed the following issues in hover highlighting in VS Code:

1. Type highlighted as a value.
![highlight_hover_error_1](https://user-images.githubusercontent.com/1297748/92630832-b90d5700-f2d0-11ea-9510-921db6ee6d4d.png)

2. Multi-line type signature incorrectly highlighted.
![highlight_hover_error_2](https://user-images.githubusercontent.com/1297748/92630841-bd397480-f2d0-11ea-9e9f-dedbf00af65e.png)

As one of the maintainers of the [VS Code syntax highlighting extension](https://github.com/JustusAdam/language-haskell) I'd like to figure out how to go about fixing these issues.

Could someone let me know how the hover syntax highlighting works in VS Code, i.e. which part of the code is responsible for generating the content of the hover boxes, and in what way is the syntax highlighting engine being called? Then I can try to solve the above two problems. **Edit**: this appears to be at [`Development.IDE.Spans.AtPoint.atPoint`](https://github.com/haskell/ghcide/blob/e837b2d0c5eb038edbadc992436c6d3aa6ba272a/src/Development/IDE/Spans/AtPoint.hs#L72) in `ghcide`. Going to experiment.

Let me know if you come across any other issues with hover syntax highlighting.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.