haskell / haskell/binary

Support decoding from a Get monad

Open
#57 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Haskell
Stars
120
Forks
70
PR merge metrics
No merged PRs in 30d

Description

I prefer not to ask for convenience functions willy-nilly, but I think refactoring `decodeFileOrFail` with this signature would be useful:

``` haskell
decodeGetFileOrFail :: Get a -> FilePath -> IO (Either (ByteOffset, String) a)
```

The reason is because there is a nontrivial chunk of code for running the incremental parser that preferably we'd avoid duplicating. I'll submit a PR soon.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading the existing decodeFileOrFail entry point and the incremental parser path it uses. Check the proposed decodeGetFileOrFail signature against the current API; done means decoding from a Get value works without duplicating the nontrivial parser-running logic.

Written by the indexing model from the issue text.

Assessment

Tech stack
haskell
Domain
data
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.