receiveHTTP does not preprocess the incoming URI before it is parsed
- Lingua principale
- Haskell
- Stelle
- 186
- Fork
- 59
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Descrizione
Because of the strict parsing of URIs by Network.URI.parseURIReference, parseRequestHead fails on this "almost valid" URI:
```
ghci> parseRequestHead ["GET http://fonts.googleapis.com/css?family=Roboto:300|Open+Sans:700|Open+Sans:300&lang=en HTTP/1.1"]
ghci> Left (ErrorParse "parseRequestHead Request command line parse failure: GET http://fonts.googleapis.com/css?family=Roboto:300|Open+Sans:700|Open+Sans:300&lang=en HTTP/1.1")
```
Replacing the pipe characters with %7C allows the URI to parse.
receiveHTTP, or maybe parseRequestHead, should probably try to escape the characters that are considered invalid for URIs, before sending the string through parseURIReference.
In that regard, `escapeURIString isAllowedInURI` from Network.URI may be handy.
(Something about "be conservative in what you send, be liberal in what you accept" prompted me to raise this issue.)
Guida per i contributori
Nessuna guida per i contributori indicizzata per questo repository
Valutazione
Questa issue non è ancora stata valutata.