hashgraph / hashgraph/full-stack-testing

Update SemanticVersion class to have hashcode function

Open
#760 0 comments 0 reactions 0 assignees View on GitHub
Bug
Dominant language
Java
Stars
9
Forks
3
PR merge metrics
No merged PRs in 30d

Description

According to "Effective Java - Joshua Bloch", Chapter -3 (Item 11): Always override hashCode when you override equals,

This is because, otherwise it would cause issues when using these objects in `HashMap` and `HashSet`

https://github.com/hashgraph/full-stack-testing/blob/main/fullstack-core/fullstack-base-api/src/main/java/com/hedera/fullstack/base/api/version/SemanticVersion.java#L145

Also we need to add relavent unit tests

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.