hardbyte / hardbyte/python-can

can.BLFReader: Stuck printing "Unknown object header version (0)", cannot error handle.

Ouverte
#1,581 2 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
bug
Langage dominant
Python
Étoiles
1.6k
Forks
697
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

### Describe the bug
When reading certain BLF files that may be corrupt, the can.BLFReader() function gets stuck with the terminal output continuously printing "Unknown object header version (0)". Because this does not raise an error flag, there is no way to get out of this loop using traditional error handling methods. It seems maybe modifying the following section of blf.py would prevent the script from getting stuck here.

```else:
LOG.warning("Unknown object header version (%d)", header_version)
pos = next_pos
continue
```

To:

```else:
raise BLFParseError("Unknown object header version (%d)", header_version) from None
```

### To Reproduce
I am not sure what is wrong with the particular BLF file this is getting stuck in but I cannot share it unfortunately.

### Expected behavior
If "Unknown Object header Version (0)" is encountered, raise an exception flag so that we can stop processing the faulted file.

### Additional context

OS and version: Windows 10
Python version: 3.11.2
python-can version: 4.1.0

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.