hardbyte / hardbyte/python-can

Async variant of BusABC?

Abierto
#1,137 5 comentarios 0 reacciones 0 asignados Ver en GitHub
api docs
Lenguaje dominante
Python
Estrellas
1.6k
Forks
697
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

I am using the asyncio support in `Notifier` which works well on reception of messages. However there is no async variant of `BusABC.send()`. It has a timeout which by default is set to `None` that may block forever according to spec. Not all interfaces seems to be using the timeout parameter and I haven't had any problem using it as-is from async tasks. But it _is_ a potential block which may halt the async event loop if called from an async task. There are other functions in the `BusABC` API that has similar timeouts, like `recv()`.

I guess the first question would be if an async variant of `BusABC.send()` is really needed or not. If the timeout is for all practical purposes not used and sends are immediate, then IMHO there is nothing wrong with this blocking call.

What would be a good approach for async? Make a new `AsyncBus` as wrapper for `BusABC` in the same manner as `ThreadSafeBus` is? I believe due to the nature of async tasks, the `send()` function would need to put the message on a queue and await a signal. A separate (non async) tx thread would be responsible for sending the message using the regular `send()` including traditional timeouts and then signal back to the sleeping async task.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.