handzlikchris / handzlikchris/FastScriptReload

Remove AutoDetectAndSetShaderMode method since it seems it does nothing

Aperta
#143 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
C#
Stelle
2.2k
Fork
167
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Except cause an exception because for some reason in one of the projects I get this:

```
System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: index
at System.Collections.Generic.List`1[T].get_Item (System.Int32 index) [0x00009] in :0
at ImmersiveVRTools.Editor.Common.WelcomeScreen.Utilities.AssetPathResolver.GetAssetFolderPathRelativeToScript (UnityEngine.ScriptableObject scriptableObject, System.Int32 folderDistanceFromFileRoot) [0x00022] in <9139b57e70db41b1b3e8ae7302e30088>:0
at FastScriptReload.Editor.FastScriptReloadPreference.SetCommonMaterialsShader (FastScriptReload.Editor.FastScriptReloadPreference+ShadersMode newShaderModeValue) [0x00001] in D:\git\borbeli\Assets\Plugins\Packages\handzlikchris.fastscriptreload\Source\Scripts\Editor\FastScriptReloadWelcomeScreen.cs:833
```

The reason I think it is not needed is that it calls FastScriptReloadPreference.SetCommonMaterialsShader which tries to set the shader on materials found in plugin's directory named Point but there are no materials in plugin's directory.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Direzione di ricerca

Start in FastScriptReloadWelcomeScreen.cs around line 833 and inspect AutoDetectAndSetShaderMode together with FastScriptReloadPreference.SetCommonMaterialsShader. Confirm how the Point material lookup causes the reported exception when no plugin materials exist. Done means the unnecessary call no longer triggers the exception and the related behavior is covered by the available project checks.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
csharp, unity
Ambito
game-dev, tooling
Tipo di issue
Bug
Difficoltà
2/5
Tempo stimato
1-3 ore
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
35/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.