handzlikchris / handzlikchris/FastScriptReload

Remove AutoDetectAndSetShaderMode method since it seems it does nothing

Open
#143 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
2.2k
Forks
167
PR merge metrics
No merged PRs in 30d

Description

Except cause an exception because for some reason in one of the projects I get this:

```
System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: index
at System.Collections.Generic.List`1[T].get_Item (System.Int32 index) [0x00009] in :0
at ImmersiveVRTools.Editor.Common.WelcomeScreen.Utilities.AssetPathResolver.GetAssetFolderPathRelativeToScript (UnityEngine.ScriptableObject scriptableObject, System.Int32 folderDistanceFromFileRoot) [0x00022] in <9139b57e70db41b1b3e8ae7302e30088>:0
at FastScriptReload.Editor.FastScriptReloadPreference.SetCommonMaterialsShader (FastScriptReload.Editor.FastScriptReloadPreference+ShadersMode newShaderModeValue) [0x00001] in D:\git\borbeli\Assets\Plugins\Packages\handzlikchris.fastscriptreload\Source\Scripts\Editor\FastScriptReloadWelcomeScreen.cs:833
```

The reason I think it is not needed is that it calls FastScriptReloadPreference.SetCommonMaterialsShader which tries to set the shader on materials found in plugin's directory named Point but there are no materials in plugin's directory.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.