hackmdio / hackmdio/hackmd-cli

Updating notes does not update all lines

Aperta
#86 4 commenti 1 reazione 0 assegnatari Vedi su GitHub
Lingua principale
TypeScript
Stelle
176
Fork
13
Merge medio
1g 4h
PR unite (30g)
5

Descrizione

First of all, thanks for maintaining this tool.

Sometimes, when using the `notes update` command, the note is not fully updated. Here is a fairly small example/reproduction:

````sh
$ hackmd-cli notes create --content='
aa

```
aab
```

aab'
ID Title User path Team path
────────────────────── ──────── ───────── ─────────
59bbDYGPSESuaJuBh_fD4A Untitled gitmd
````
to create a note with some content. Now, update it with some other content:
````
$ hackmd-cli notes update --noteId 59bbDYGPSESuaJuBh_fD4A --content='
aa

```json
aabc
```

aabc'
````
However, the last modification (the last line) is not taken into account:
````
$ hackmd-cli export --noteId 59bbDYGPSESuaJuBh_fD4A

aa

```json
aabc
```

aab
````

If I do the `hackmd-cli notes update` command again, the content of the note matches what is required.
However, I've seen some old content/new content pairs where `hackmd-cli notes update` does nothing...

This seems to be a hackmd API bug (rather than the CLI), as I tried to directly write the HTTP requests, and it fails. But I could not find any github repository where we can file issues on the API itself. Feel free to redirect me if I'm not opening the issue in the right repo!

(while writing the HTTP requests by hand, I've also seen a case where writing a newline at the end of the JSON payload would change the outcome of the "update" API request... if that helps to track the bug)

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.