hackmdio / hackmdio/codimd

Failed Login should result in the appropriate HTTP-Status Code

Aperta
#657 4 commenti 0 reazioni 0 assegnatari Vedi su GitHub
auth provider enhancement upstream
Lingua principale
JavaScript
Stelle
10.1k
Fork
1.1k
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Right now, If you try to login with weird credentials, you'll receive an HTTP 302 redirect and get back to the root of the project. Which will happily claim to be HTTP 200 OK. At no point is there a machine-readable mentioning of the failed login.

This is bad for at least two reasons: You can't properly script a login and browsers will offer to save your credentials, even if they are faulty.

I would like to suggest to change this to actually at some point reply with a HTTP 400-ish response code. Perhaps 401 Unauthorized.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.