hackmdio / hackmdio/codimd

Failed Login should result in the appropriate HTTP-Status Code

Open
#657 4 comments 0 reactions 0 assignees View on GitHub
auth provider enhancement upstream
Dominant language
JavaScript
Stars
10.1k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

Right now, If you try to login with weird credentials, you'll receive an HTTP 302 redirect and get back to the root of the project. Which will happily claim to be HTTP 200 OK. At no point is there a machine-readable mentioning of the failed login.

This is bad for at least two reasons: You can't properly script a login and browsers will offer to save your credentials, even if they are faulty.

I would like to suggest to change this to actually at some point reply with a HTTP 400-ish response code. Perhaps 401 Unauthorized.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.