hackmdio / hackmdio/codimd

Revisions should not url_encode or at least url_encode(diff("content"))

Abierto
#522 1 comentario 0 reacciones 0 asignados Ver en GitHub
database/sequelize discussion
Lenguaje dominante
JavaScript
Estrellas
10.1k
Forks
1.1k
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

In #521 it looks like the `Revisions` table does something like this:

diff(url_encode("content"))

This makes little sense, as the diffing will always yield all of the document. And those are stored in `lastContent` and `content` anyway.

This should be reversed to be

url_encode(diff("content"))

I'm not even entirely sure why the url-encode is done in the first place, but it appears to be there.

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Locate the Revisions table implementation and the code related to #521 that applies url_encode and diff to content. Check why encoding currently happens before diffing, then verify that diffing content produces a focused revision and that URL encoding is applied afterward; use any related tests or revision data available in the repository to confirm the result.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
javascript
Área
databases
Tipo de issue
Error
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
42/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.