hackmdio / hackmdio/codimd

Revisions should not url_encode or at least url_encode(diff("content"))

Open
#522 1 comment 0 reactions 0 assignees View on GitHub
database/sequelize discussion
Dominant language
JavaScript
Stars
10.1k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

In #521 it looks like the `Revisions` table does something like this:

diff(url_encode("content"))

This makes little sense, as the diffing will always yield all of the document. And those are stored in `lastContent` and `content` anyway.

This should be reversed to be

url_encode(diff("content"))

I'm not even entirely sure why the url-encode is done in the first place, but it appears to be there.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.