hackmdio / hackmdio/codimd

Ctrl+Alt+E Yields € symbol in addition to switching to edit mode.

Aperta
#355 7 commenti 0 reazioni 0 assegnatari Vedi su GitHub
bug minor UI/UX
Lingua principale
JavaScript
Stelle
10.1k
Fork
1.1k
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

If I'm in "both" mode, and press Ctrl+Alt+E to switch to "edit" mode, It will work, but it will also put an `€` in the current cursor position.

An `event.preventDefault()` should probably fix this, however, this should only be done, if there's actually a switch happening (meaning: If I'm *already* in edit-mode, please don't `preventDefault`, or we won't be able to type € symbols any more).

**To reproduce**

* (you may need an european keyboard layout, I'm not sure)
* Set any pad to "both" mode where you can see the editor and rendered html at once.
* Make sure, your focus is in the editor, so you can actually type
* press Ctrl+Alt+E

**Current Result**
* The view is being switched *and* you also get € at the current cursor position

**Desired Result**
* when *already* in edit mode: just type the €
* when *not* in edit mode: just switch to edit

I'm not sure if other (Ctrl+Alt+V or Ctrl+Alt+B) shortcuts interfere with anything, they do not on my layout. But this could be a general pattern, I believe.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.