DnsNameResolver seems overly strict when validating service config
- Lenguaje dominante
- Java
- Estrellas
- 12.1k
- Forks
- 4k
- Merge medio
- 2 d 17 h
- PR fusionados (30 d)
- 37
Descripción
DnsNameResolver only allows a pre-determined set of keys used as filters, _in the entire list_:
https://github.com/grpc/grpc-java/blob/c606519a5d75b844bfc8bd243c6c9ebe1c742f96/core/src/main/java/io/grpc/internal/DnsNameResolver.java#L543-L545
That means we can never add a new filter key. That seems like a very bad idea. I don't know if this is cross-language, but the precise behavior doesn't seem nailed down in https://github.com/grpc/proposal/blob/master/A2-service-configs-in-dns.md .
CC @dfawley, @markdroth
Guía de contribución
Línea de trabajo
Start with DnsNameResolver.java at the linked validation logic around lines 543–545, then read the A2 service-configs-in-DNS proposal and review closed pull request #10285. Establish the intended behavior for filter keys before changing the implementation; done means the behavior is resolved and the Java implementation matches the agreed specification.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- java
- Área
- networking
- Tipo de issue
- Error
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Estado de actividad
- Estancado
- Claridad
- Necesita aclaración
- Aptitud para principiantes
- 25/100