GrpclbLoadBalancer should have full control over the lifecycle of StopWatch
Offen
code health
- Vorherrschende Sprache
- Java
- Sterne
- 12.1k
- Forks
- 4k
- Ø Merge
- 2 T. 17 Std.
- Gemergte PRs (30 T.)
- 37
Beschreibung
Would be good to add another `GrpclbLoadBalancer` constructor without the `StopWatch` argument. The old constructor is just `@VisibleForTesting`, and `GrpclbLoadBalancerProvider` will call the new constructor. In this way, `GrpclbLoadBalancer` can have full control over the lifecycle of the `StopWatch`.
Beitragsleitfaden
Rechercherichtung
Start by reading GrpclbLoadBalancer and GrpclbLoadBalancerProvider, focusing on the existing constructor and StopWatch ownership. Add the provider-facing constructor while retaining the testing constructor, then verify that the load balancer controls the StopWatch lifecycle as intended.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- grpc, java
- Bereich
- networking
- Issue-Typ
- Refactoring
- Schwierigkeit
- 2/5
- Geschätzter Aufwand
- 1-3 Stunden
- Aktivitätsstatus
- Veraltet
- Klarheit
- Klar beschrieben
- Anfängerfreundlichkeit
- 35/100