grpc / grpc/grpc-java

Provide JUnit 5 GrpcTestExtension

Abierto
#5,331 31 comentarios 39 reacciones 1 asignado Reclamado por @ejona86 Ver en GitHub
Lenguaje dominante
Java
Estrellas
12.1k
Forks
4k
Merge medio
2 d 17 h
PR fusionados (30 d)
37

Descripción

### What version of gRPC are you using?

1.18.0

### What did you expect to see?

In order to be able to test with JUnit 5 I would like to have a comparable solution like `GrpcCleanupRule` but as JUnit 5 extension.

### Example

In my PoC project [mmichaelis/poc-grpc][] you may see an example, which is very similar to your `GrpcCleanupRule` (because that was my intention :smile:): In module [grpc-test][] you will find the class [GrpcTestExtension][] and an example usage in [HelloServiceImplTest][].

### Help wanted?

I may assist in adding this to the `grpc-java` project, but there are several questions:

* First of all: Do you like the extension?
* Where to place the JUnit 5 extension? Into testing module? Or an extra module?
* And if it is an extra module: How to share code? My intention would be to refactor `GrpcCleanupRule`, so that `GrpcTestExtension` and the JUnit 4 rule share as much code as possible.

[mmichaelis/poc-grpc]: "mmichaelis/poc-grpc: Proof-of-Concept for gRPC"
[grpc-test]: "poc-grpc/grpc-parent/grpc-test at master · mmichaelis/poc-grpc"
[GrpcTestExtension]: "poc-grpc/GrpcTestExtension.java at master · mmichaelis/poc-grpc"
[HelloServiceImplTest]: "poc-grpc/HelloServiceImplTest.java at master · mmichaelis/poc-grpc"

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.