grpc / grpc/grpc-java

Document multiple EquivalentAddressGroups vs multiple SocketAddresses in NameResolver

Aperta
#5,263 2 commenti 2 reazioni 1 assegnatario Rivendicata da @zhangkun83 Vedi su GitHub
Lingua principale
Java
Stelle
12.1k
Fork
4k
Merge medio
2g 17h
PR unite (30g)
37

Descrizione

Currently the javadocs don't state when to use multiple `EquivalentAddressGroup`s or multiple `SocketAddress`es in a single `EquivalentAddressGroup`.

**io.grpc.EquivalentAddressGroup**

> A group of SocketAddresses that are considered equivalent when channel makes connections.
>
> Usually the addresses are addresses resolved from the same host name, and connecting to any of them is equally sufficient. They do have order. An address appears earlier on the list is likely to be tried earlier.

**io.grpc.NameResolver.Listener.onAddresses(List, Attributes)**

> Handles updates on resolved addresses and attributes.
>
> Implementations will not modify the given servers.
>
> **Parameters:**
> - **servers** the resolved server addresses. An empty list will trigger onError
> - **attributes** extra information from naming system.

* Do I use multiple `SocketAddress`es if there are multiple paths to one and the same server, such as `10.1.2.3` , `127.0.0.1` or `::1`? (Would that ever happen?)
* Or do I always create new `EquivalentAddressGroup`s for each address? (But then why am I able to list more addresses?)

It is also unsure when (and for what) the attributes on the single `EquivalentAddressGroup` is used and when (and for what) the attributes from the `onAddresses` call is used, and finally whether they are merged somehow or not.

## Affects

* grpc-core

## Related

* https://github.com/grpc/grpc-java/issues/1770
* https://github.com/grpc/grpc-java/issues/4302
* https://github.com/grpc/grpc-java/issues/5213

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.