grpc / grpc/grpc-java

Netty streams should reduce the capacity of pooled buffers passed to sendFrame

Open
#452 3 comments 0 reactions 0 assignees View on GitHub
performance
Dominant language
Java
Stars
12.1k
Forks
4k
Avg merge
2d 17h
Merged PRs (30d)
37

Description

When a small write and flush is passed through the framer we hold the full 4k of the buffer until the write completes. By reducing the capacity of a pool direct buffer to the readably byte limit we immediately release the unwritten portion of the buffer back to the pool.

This may or may not have an impact on performance and utility should be evaluated by bencmarking. It may improve performance by making more bytes available to thread-local allocation. The most likely benchmarks to be impacted would be streaming ones that write and flush many messages in a tight loop as it would alleviate buffer-arena locks.

Contributor guide

Open the contributing guide

Research direction

Start by locating the Netty framer path that handles a small write and flush, focusing on pooled direct buffers and the readable-byte limit. Benchmark streaming workloads that write and flush many messages in a tight loop, and consider the work done when the unwritten buffer portion is returned to the pool and performance impact is measured.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend, performance
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.