grpc / grpc/grpc-java

Remove internal-only methods from testing package

Aperta
#3,105 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
code health
Lingua principale
Java
Stelle
12.1k
Fork
4k
Merge medio
2g 17h
PR unite (30g)
37

Descrizione

As mentioned in comments in #3099, there are some issues and limitation to the current unit test tools:

- It's hard to test a user-defined generic interceptor.
- People are abusing `NoopClientCall`, using it as an alternative of `mock(ClientCall.class)`, which is as bad as a mock.
- `TestMethodDescriptors.noopMarshaller` does not gain much benefit. It violates the interface's contract, it's equivalent to a `mock(Marshaller.class)`, and it does not work in InProcess transport or interop test.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.