grpc / grpc/grpc-java

Remove internal-only methods from testing package

Open
#3,105 1 comment 0 reactions 0 assignees View on GitHub
code health
Dominant language
Java
Stars
12.1k
Forks
4k
Avg merge
2d 17h
Merged PRs (30d)
37

Description

As mentioned in comments in #3099, there are some issues and limitation to the current unit test tools:

- It's hard to test a user-defined generic interceptor.
- People are abusing `NoopClientCall`, using it as an alternative of `mock(ClientCall.class)`, which is as bad as a mock.
- `TestMethodDescriptors.noopMarshaller` does not gain much benefit. It violates the interface's contract, it's equivalent to a `mock(Marshaller.class)`, and it does not work in InProcess transport or interop test.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.