binder: A Channel might check its SecurityPolicy even after declaring termination
- Langage dominant
- Java
- Étoiles
- 12.1k
- Forks
- 4k
- Merge moyen
- 2 j 17 h
- PR mergées (30 j)
- 37
Description
### What version of gRPC-Java are you using?
master/HEAD on any version of Android
### What did you expect to see?
Some reasoning/guarantee that a Channel will no longer call into its SecurityPolicy after it declares termination.
### Steps to reproduce the bug
One of many ways is to call `ManagedChannel.shutdownNow()` while it's establishing a new connection.
### Analysis
When using `AsyncSecurityPolicy`, `BinderClientTransport` calls `checkServerAuthorizationAsync()` while holding its `this` lock and only after carefully checking that it's not in state `SHUTDOWN` or `SHUTDOWN_TERMINATED`. This is safe because `clientTransportListener.transportTerminated()` is only called after transitioning into those states while holding the same lock. (We do this on the assumption that `AsyncSecurityPolicy` checks don't block)
However, when using an ordinary blocking `SecurityPolicy`, `checkServerAuthorizationAsync()` is implemented by `submit()`ing this presumably blocking work to `offloadExecutor`. We first do the same state checks, but because we release the `this` lock, the transport could shutdown and declare termination after this submission but before the offload executor actually calls `checkAuthorization()`.
Guide de contribution
Ouvrir le guide de contribution
Piste de recherche
Commencez par lire le chemin AsyncSecurityPolicy de BinderClientTransport, en vérifiant en particulier checkServerAuthorizationAsync(), checkAuthorization(), shutdownNow() et le callback transportTerminated(). Suivez la soumission à offloadExecutor et les transitions d’état afin de déterminer si l’autorisation peut s’exécuter après la terminaison ; le travail est considéré comme terminé lorsque la garantie du cycle de vie est établie et couverte par un test de régression ou un raisonnement clairement documenté.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- java
- Domaine
- backend-api-design, security
- Type d'issue
- Bug
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Activité
- Calme
- Clarté
- À clarifier
- Accessibilité débutants
- 42/100