Backend Service Metric implementation should change for A75 Aggregate Cluster Fixes
- Lingua principale
- Java
- Stelle
- 12.1k
- Fork
- 4k
- Merge medio
- 2g 17h
- PR unite (30g)
- 37
Descrizione
https://github.com/grpc/proposal/blob/master/A75-xds-aggregate-cluster-behavior-fixes.md#changes-to-backend-service-metric-label-plumbing
> gRFC A89 Backend Service Metric Label has a different implementation approach dependent on whether this gRFC has been implemented. If A89 was implemented before this gRFC, then backend service plumbing needs to change to go through the cds policy instead of the xds_cluster_impl policy, as documented in A89.
It doesn't appear this change was done:
https://github.com/grpc/grpc-java/blob/096c4d9f915fcbef342311a794378194f526bd54/xds/src/main/java/io/grpc/xds/ClusterImplLoadBalancer.java#L403
https://github.com/grpc/grpc-java/blob/096c4d9f915fcbef342311a794378194f526bd54/xds/src/main/java/io/grpc/xds/ClusterImplLoadBalancer.java#L156-L162
Guida per i contributori
Apri la guida per i contributori
Valutazione
Questa issue non è ancora stata valutata.