grpc / grpc/grpc-java

Backend Service Metric implementation should change for A75 Aggregate Cluster Fixes

Open
#12,431 0 comments 0 reactions 1 assignee Claimed by @kannanjgithub View on GitHub
enhancement
Dominant language
Java
Stars
12.1k
Forks
4k
Avg merge
2d 17h
Merged PRs (30d)
37

Description

https://github.com/grpc/proposal/blob/master/A75-xds-aggregate-cluster-behavior-fixes.md#changes-to-backend-service-metric-label-plumbing

> gRFC A89 Backend Service Metric Label has a different implementation approach dependent on whether this gRFC has been implemented. If A89 was implemented before this gRFC, then backend service plumbing needs to change to go through the cds policy instead of the xds_cluster_impl policy, as documented in A89.

It doesn't appear this change was done:
https://github.com/grpc/grpc-java/blob/096c4d9f915fcbef342311a794378194f526bd54/xds/src/main/java/io/grpc/xds/ClusterImplLoadBalancer.java#L403

https://github.com/grpc/grpc-java/blob/096c4d9f915fcbef342311a794378194f526bd54/xds/src/main/java/io/grpc/xds/ClusterImplLoadBalancer.java#L156-L162

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.