gridscale / gridscale/gridscale_api_client_python

Rename ssh methods

未关闭
#12 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Python
星标
5
派生
0
PR 合并指标
30 天内没有已合并 PR

描述

To make this client more in line with the [official API](https://gridscale.io/en/api-documentation/index.html#tag/SSH-key) I'd to propose a rename of the following methods:

- get_ssh_keys
- get_ssh_key
- create_ssh_key
- update_ssh_key
- delete_ssh_key
- get_ssh_key_events

`ssh_key` is canonically without the underscore in the API. The new function names would then be

- get_sshkeys
- get_sshkey
- create_sshkey
- update_sshkey
- delete_sshkey
- get_sshkey_events

For backwards-compat we could alias the methods to their old names.

It's a small annoyance, but I still wanted to mention it. I'm ready to work an a pull request if this change finds acceptance.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。