graphql / graphql/graphql.github.io
Dark mode code block ("CodeMirror") sections display a mysterious white square
- Langage dominant
- TypeScript
- Étoiles
- 889
- Forks
- 1.5k
- Merge moyen
- 4 j 12 h
- PR mergées (30 j)
- 21
Description
### Description
When looking at the interactive code block (maybe called "CodeMirror") sections in dark mode, there is a white square that doesn't seem to do anything. I could see this on Chrome, Firefox, and Safari.
### Steps to Reproduce
1. Go to a page with an interactive code block (e.g., https://graphql.org/learn/queries/)
2. You may see something like this:
### Expected Result
I would expect not to see the white square.
### Actual Result
...I saw the white square.
### Additional Context
There's a small chunk of CSS that sets this white square to be white:
```css
.CodeMirror-scrollbar-filler,
.CodeMirror-gutter-filler {
background-color: white; /* The little square between H and V scrollbars */
}
```
On light mode, this makes the square invisible (because the background is also white). However, this CSS doesn't seem to account for dark mode.
My proposed fix is a little lazy. I'll just make the square invisible on dark mode:
```css
.CodeMirror-scrollbar-filler:is(html[class~=dark] *) ,
.CodeMirror-gutter-filler:is(html[class~=dark] *) {
background-color: transparent; /* The little square between H and V scrollbars */
}
```
I think that a larger fix might be ideal in the future, because the scrollbars are invisible anyway, so this square doesn't seem to have any use (see: #1617). But maybe my proposed fix is OK in the meantime.
Guide de contribution
Ouvrir le guide de contribution
Piste de recherche
Commencez sur graphql.org/learn/queries/ et examinez la section interactive de CodeMirror en mode sombre, puis localisez les règles CSS pour .CodeMirror-scrollbar-filler et .CodeMirror-gutter-filler. C’est terminé lorsque le carré blanc n’est plus visible en mode sombre, tout en veillant à ce que le bloc de code interactif fonctionne toujours ; vérifiez le résultat dans Chrome, Firefox et Safari.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- css
- Domaine
- frontend, web-dev
- Type d'issue
- Bug
- Difficulté
- 2/5
- Temps estimé
- 1-3 heures
- Activité
- À l'abandon
- Clarté
- Clairement spécifiée
- Accessibilité débutants
- 52/100