graphql-python / graphql-python/sanic-graphql

Handle Access-Control-Allowed-Headers in CORS preflight

Open
#4 4 comments 1 reaction 0 assignees View on GitHub
Dominant language
Python
Stars
148
Forks
17
PR merge metrics
No merged PRs in 30d

Description

The CORS implementation added by the fix/preflight branch is incomplete. You must also respond to the headers requests. My client (graphiql on chrome) is trying to use a content-type header, and is therefore being rejected.

https://developer.mozilla.org/en-US/docs/Web/HTTP/Access_control_CORS#Access-Control-Allow-Headers

Also, kind of surprising that CORS is enabled by default. You may want to put a warning somewhere in the readme!

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.