graphql-python / graphql-python/graphql-core-legacy

Catching exceptions

Aperta
#202 1 commento 1 reazione 0 assegnatari Vedi su GitHub
Lingua principale
Python
Stelle
372
Fork
175
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Using Graphene with graphql-core 2.0, I was able to write middleware that would catch errors:

```py
class ErrorHandlerMiddleware():
def resolve(self, next, root, info, **args):
try:
return next(root, info, **args)
except Exception as ex:

# log error with Sentry
info.context.sentry.captureException()

# Return a generic rejection
return GraphQLError("System error. Please try again later.")
```

It wasn't perfect. _Both_ the original exception and GraphQLError would wind up appearing as Sentry issues, but it'd at least get reported and send back a generic error to the user.

I've since bumped graphql-core to 2.1 to take advantage of the logging improvements, but I'm not clear on how the above could be achieved in 2.1? With the latest version, the original exception winds up in the `message` field of the response... potentially exposing sensitive info, like SQL errors, etc.

Could you please post an example in the README of how one might write middleware or use the new logging set-up to capture errors and replace the response with a generic message? I think that would be a really common use-case that many would find useful.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.