graphql-python / graphql-python/graphql-core-legacy

Enum default_value serialization issue

Ouverte
#166 4 commentaires 1 réaction 0 personnes assignées Voir sur GitHub
Langage dominant
Python
Étoiles
372
Forks
175
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

Originally reported in [graphene issue #691](https://github.com/graphql-python/graphene/issues/691)

Argument default_value serializes enum value instead of name. graphql spec does not support enum values and graphql-js serializes enums to the name not value. graphql-python is not consistent with graphql-js. I attempted to find a workaround by setting the enum value to a string of the name but teh result is a string that includes escaped quotes.

Using the name of the enum doesn't work:

```python
class MyEnum(graphene.Enum):
FOO=0
BAR=1

foobar = graphene.List(FooBar, my_enum=graphene.Argument(MyEnum, default_value=MyEnum.FOO.name))
```

This results in the defaultValue being ```"\"FOO\""```. This does not follow the graphql spec for enums and breaks with third party introspection. Specifically i'm trying to stitch a graphene remote schema and the invalid defaultValue results in a null returned in the merged schema (using graphql-tools).

Using a string value doesn't work either:

```python
class MyEnum(graphene.Enum):
FOO="FOO"
BAR="BAR"
```
This also doesn't work with using MyEnum.FOO.value for default_value nor setting it specifically to the static string "FOO".

I tried looking for how default_value gets resolved for enums but haven't been able to track it down. I think if we can just get the string value for default_value to not include the escaped string quotes then my schema stitching will work. I haven't been able to figure out how to define an enum so that this will happen.

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Piste de recherche

Start by reproducing the enum argument default_value examples and tracing how default values are serialized during schema introspection. Compare the result with graphql-js behavior; done means an enum default is emitted as its name without escaped string quotes and can be consumed by graphql-tools schema stitching.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
graphql, python
Domaine
api, backend
Type d'issue
Bug
Difficulté
3/5
Temps estimé
1-2 jours
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
38/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.