graphql-python / graphql-python/graphql-core-legacy
Lex comments
- Vorherrschende Sprache
- Python
- Sterne
- 372
- Forks
- 175
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Beschreibung
Right now graphql-core in the lex pass completely omits comments. If you want to consume the content of comments in tooling, you are out of the luck.
Python graphql shoudl mimic graphql-js and do this. Lee Byron did this here https://github.com/graphql/graphql-js/commit/165b9d3a0b913d792501b0ce2829ad417d83122d by making the stream of lex tokens a doubly-linked list so you can "peek" backwards and inspect the contents of comments.
I'll submit a pull request at some point to do this but if someone feels like doing it go nuts!
Beitragsleitfaden
Für dieses Repository ist kein Beitragsleitfaden indexiert
Rechercherichtung
Start by reading the graphql-core lex pass and comparing its token stream with the linked graphql-js commit. The issue describes exposing comments through a doubly-linked token list so tooling can inspect them; done means comment content is available to consumers without being omitted.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- python
- Bereich
- backend-api-design
- Issue-Typ
- Feature
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 35/100