graphql-python / graphql-python/graphql-core-legacy

Lex comments

Open
#128 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
372
Forks
175
PR merge metrics
No merged PRs in 30d

Description

Right now graphql-core in the lex pass completely omits comments. If you want to consume the content of comments in tooling, you are out of the luck.

Python graphql shoudl mimic graphql-js and do this. Lee Byron did this here https://github.com/graphql/graphql-js/commit/165b9d3a0b913d792501b0ce2829ad417d83122d by making the stream of lex tokens a doubly-linked list so you can "peek" backwards and inspect the contents of comments.

I'll submit a pull request at some point to do this but if someone feels like doing it go nuts!

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.