graphql-python / graphql-python/graphene

Why SubclassWithMeta.__init_subclass__ terminates the super() chain?

Abierto
#1,233 0 comentarios 1 reacción 0 asignados Ver en GitHub
✨ enhancement
Lenguaje dominante
Python
Estrellas
8.2k
Forks
818
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Is there a great reason why `graphene.utils.subclass_with_meta.SubclassWithMeta.__init_subclass__`, doesn't call `super().__init_subclass__()`?
https://github.com/graphql-python/graphene/blob/master/graphene/utils/subclass_with_meta.py#L21-#L46

The issue with this is IMO the following:

- Class `Foo` has defined a custom `__init_subclass__`.
- Class `Bar` derives from `Foo` and e.g. `graphene.types.ObjectType`.

Now if `Foo` is accidentally placed after `ObjectType` in `Bar`'s inheritance list, `Foo.__init_subclass__` will never be run.

Here's a quick demo:

```
from graphene.types import ObjectType

class Foo:
def __init_subclass__(cls):
print(f"Init Foo's subclass: {cls.__name__}")
super().__init_subclass__()

class Bar1(Foo, ObjectType):
pass

class Bar2(ObjectType, Foo):
pass
```

>Output:
>```
>Init Foo's subclass: Bar1
>```

[My proposed fix PR](https://github.com/graphql-python/graphene/pull/1234) would simply add `super().__init_subclass__()` to the last line of `SubclassWithMeta.__init_subclass__`.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Línea de trabajo

Start with graphene/utils/subclass_with_meta.py at lines 21-46 and reproduce the Foo, Bar1, and Bar2 example from the issue. Review the proposed fix in graphene/pull/1234 and verify that SubclassWithMeta.__init_subclass__ no longer stops the cooperative super() chain. Done means Foo.__init_subclass__ runs for both inheritance orders without breaking existing behavior.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
python
Área
backend
Tipo de issue
Error
Dificultad
2/5
Tiempo estimado
1-3 horas
Estado de actividad
Estancado
Claridad
Bien especificado
Aptitud para principiantes
25/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.