graphql-python / graphql-python/graphene-sqlalchemy

required should be inferred from the return type of a hybrid property

Ouverte
#427 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Python
Étoiles
985
Forks
223
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

With a definition like:
```
@hybrid_property
def is_active(self) -> bool:
return self.state == 'ACTIVE'
```

The resulting graphql field type is currently marked `Boolean` unless overridden by `ORMField()`. Column properties correctly determine the nullability from the column definition. It seems reasonable to do the same for the hybrid_property based on the declared type. If the return type were `bool | None`, then it would be optional, otherwise it should be required.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.