graphql-python / graphql-python/graphene-sqlalchemy

Add a way to serve custom properties on model classes

未关闭
#103 18 条评论 11 个 reaction 已指派 0 人 在 GitHub 查看
enhancement
主要语言
Python
星标
985
派生
223
PR 合并指标
30 天内没有已合并 PR

描述

In SQLAlchemy, you often want to provide additional custom properties on the model classes, like this:
```python
class User(Base):
__tablename__ = 'users'
first_name = Column(String)
last_name = Column(String)

@property
def full_name(self):
return self.first_name + ' ' + self.last_name
```
Unfortunately, such properties are currently not made accessible in GraphQL by graphene_sqlalchemy. While there is a way to exclude existing column properties using the Meta attributes `exclude_fields` and `only_fields`, there is no way to include custom properties such as `full_name` from the above model.

One possible solution is to use [hybrid properties](http://docs.sqlalchemy.org/en/latest/orm/extensions/hybrid.html) which are now supported by graphene_sqlalchemy since 2.0. However, "ordinary" properties should also be supported. Often you dont really want or need hybrid properties - it is not always necessary or feasible to provide the property on the class level. Also, the conversion of hybrid properties currently has the limitation that it always generates `String` fields.

So I believe we need some mechanism for proxying arbitrary properties from SQLAlchemy to Graphene objects. I'm not yet sure whether all custom public properties (i.e. those not starting with an underscore) except those who are explicitly excluded should be proxied by default (like it is done with hybrid properties), or whether there should be a Meta attribute with a list of properties that must be explicitly set.

We probably also need to add a way to specify which type the (normal or hybrid) properties shall be converted to. This could also be defined in a Meta attribute, or maybe we could check for Python type hints if nothing is defined, like this:
```python
def full_name(self) -> str:
return self.first_name + ' ' + self.last_name

def current_age(self) -> int:
return current_year() - self.year_of_birth
```

I am willing to contribute with code, but first I want to get some feedback regarding this idea from others.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。