graphql-python / graphql-python/graphene-mongo

Forced to use relay pagination on list of embedded documents?

Abierto
#162 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Lenguaje dominante
Python
Estrellas
288
Forks
111
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Suppose I have this document structure:

class PersonModel(EmbeddedDocument):
    name = StringField()

class HouseModel(Document):
    people = ListField(EmbeddedDocumentField(PersonModel))

Then I define my MongoengineObjectTypes:

class Person(MongoengineObjectType):
    class Meta:
        model = PersonModel
        # no interface, since I want to access the people directly

class House(MongoengineObjectType):
    class Meta:
        model = HouseModel
        interfaces = (Node,)

Then I build my schema:

class Query(graphene.ObjectType):
    node = Node.Field()
    houses = MongoengineConnectionField(House)

schema = graphene.Schema(query=Query, types=[House, Person])

This spits out an unfriendly error:

Traceback (most recent call last):
  File "test.py", line 32, in <module>
    schema = graphene.Schema(query=Query, types=[House, Person])
  File "%python39%\lib\site-packages\graphene\types\schema.py", line 78, in __init__
    self.build_typemap()
  File "%python39%\lib\site-packages\graphene\types\schema.py", line 167, in build_typemap
    self._type_map = TypeMap(
  File "%python39%\lib\site-packages\graphene\types\typemap.py", line 80, in __init__
    super(TypeMap, self).__init__(types)
  File "%python39%\lib\site-packages\graphql\type\typemap.py", line 31, in __init__
    self.update(reduce(self.reducer, types, OrderedDict()))  # type: ignore
  File "%python39%\lib\site-packages\graphene\types\typemap.py", line 88, in reducer
    return self.graphene_reducer(map, type)
  File "%python39%\lib\site-packages\graphene\types\typemap.py", line 117, in graphene_reducer
    return GraphQLTypeMap.reducer(map, internal_type)
  File "%python39%\lib\site-packages\graphql\type\typemap.py", line 109, in reducer
    field_map = type_.fields
  File "%python39%\lib\site-packages\graphql\pyutils\cached_property.py", line 22, in __get__
    value = obj.__dict__[self.func.__name__] = self.func(obj)
  File "%python39%\lib\site-packages\graphql\type\definition.py", line 198, in fields
    return define_field_map(self, self._fields)
  File "%python39%\lib\site-packages\graphql\type\definition.py", line 212, in define_field_map
    field_map = field_map()
  File "%python39%\lib\site-packages\graphene\types\typemap.py", line 286, in construct_fields_for_type
    for arg_name, arg in field.args.items():
  File "%python39%\lib\site-packages\graphene_mongo\fields.py", line 68, in args
    return to_arguments(
  File "%python%\lib\site-packages\graphene\types\argument.py", line 80, in to_arguments
    extra_args = sorted(extra_args.items(), key=lambda f: f[1])
TypeError: '<' not supported between instances of 'Person' and 'ID'

But if I add interfaces = (Node,) to the meta of Person the error goes away. However, I am also now forced to paginate through data which I know will also be only a small collection.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Reproduce la configuración del esquema de test.py y empieza en graphene_mongo/fields.py, donde los argumentos del campo de conexión llegan a la ordenación de argumentos de Graphene. Comprueba cómo un tipo Person embebido sin Node provoca el TypeError y verifica después que la construcción del esquema se realiza correctamente, mientras la lista people embebida sigue siendo directamente accesible sin forzar la paginación mediante Connection.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
graphql, mongodb, python
Área
api, backend, database
Tipo de issue
Error
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
42/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.