graphprotocol / graphprotocol/graph-node

[Feature] Differentiate prometheus metric for large vs non-large notifications

Open
#4,535 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement ops Stale
Dominant language
Rust
Stars
3.2k
Forks
1.1k
Avg merge
4d 1h
Merged PRs (30d)
1

Description

Description

It would be great if there was a prometheus metric which captures the count of large notifications. We have a counter for all notifications, it would be great if either there was a separate counter for large notifications or a field which differentiates large vs small in the global counter.

Are you aware of any blockers that must be resolved before implementing this feature? If so, which? Link to any relevant GitHub issues.

Nope

Some information to help us out
  • Tick this box if you plan on implementing this feature yourself.
  • I have searched the issue tracker to make sure this issue is not a duplicate.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the existing notification counter in store/postgres/src/notification_listener.rs at the linked lines 394-396. Trace how notification size is available at that entry point and choose the metric representation requested in the issue. Done means Prometheus exposes counts that distinguish large notifications from non-large notifications.

Written by the indexing model from the issue text.

Assessment

Tech stack
prometheus, rust
Domain
observability
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.