graphprotocol / graphprotocol/graph-node
Priority of toml config vs env vars for connection pool size
还没有人认领这个 Issue。
- 主要语言
- Rust
- 星标
- 3.2k
- 派生
- 1.1k
- 平均合并
- 4 天 1 小时
- 30 天内合并 PR
- 1
描述
Do you want to request a feature or report a bug?
Neither
What is the current behavior?
It seems that setting the size of a connection pool with the config file takes precedence over using STORE_CONNECTION_POOL_SIZE.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
Start a graph node which uses
[store]
[store.primary]
connection = "<%= pgString %>"
pool_size = [
{ node = ".*", size = 30 },
]
and start the node with STORE_CONNECTION_POOL_SIZE=50. Then check the pool size using graphman and see that the config takes precedence.
What is the expected behavior?
I would expect the env var to take precedence over the config. Though I understand the env var isn't as fine grained.
Maybe I'm misunderstanding what STORE_CONNECTION_POOL_SIZE is meant for relative to pool_size in [store]?
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
使用 [store.primary] 中的 TOML pool_size 设置和 STORE_CONNECTION_POOL_SIZE=50 重现配置,然后使用 graphman 检查生成的池大小。确定细粒度 pool_size 设置与环境变量之间预期的优先级,并通过有针对性的测试或记录的结果验证所选择的行为。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- rust
- 领域
- backend, databases
- Issue 类型
- 缺陷
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 活跃度
- 冷清
- 描述清晰度
- 基本清楚
- 新手友好度
- 48/100