grafana / grafana/pyroscope-python
pyspy: sampler thread shutdown blocks until next sample
- Langage dominant
- Rust
- Étoiles
- 4
- Forks
- 2
- Merge moyen
- 2 j 4 h
- PR mergées (30 j)
- 5
Description
looks like this code
```
let sampler_output = sampler.take_while(|_x| running.load(Ordering::Relaxed));
```
blocks until the next sample (up to 10ms with default config)
We should consider exposing the channel so that we don't wait for 10ms
Guide de contribution
Aucun guide de contribution indexé pour ce dépôt
Piste de recherche
Start at the sampler.take_while closure shown in the issue and read the sampler shutdown path, focusing on how the running flag interacts with waiting for the next sample. Confirm the default 10ms wait, then verify that stopping the sampler completes without unnecessarily waiting for another sample.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- rust
- Domaine
- performance, tooling
- Type d'issue
- Bug
- Difficulté
- 3/5
- Temps estimé
- 1-2 jours
- Activité
- Calme
- Clarté
- Plutôt claire
- Accessibilité débutants
- 52/100