grafana / grafana/pyroscope-python

pyspy: sampler thread shutdown blocks until next sample

Open
#115 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
4
Forks
2
Avg merge
2d 4h
Merged PRs (30d)
5

Description

looks like this code
```
let sampler_output = sampler.take_while(|_x| running.load(Ordering::Relaxed));
```
blocks until the next sample (up to 10ms with default config)
We should consider exposing the channel so that we don't wait for 10ms

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the sampler.take_while closure shown in the issue and read the sampler shutdown path, focusing on how the running flag interacts with waiting for the next sample. Confirm the default 10ms wait, then verify that stopping the sampler completes without unnecessarily waiting for another sample.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
performance, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.