grafana / grafana/pyroscope-java

The Java Pyroscope agent does not use `pyroscope.application.name ` when profiling Gradle assemblies

Aperta
#202 0 commenti 2 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Java
Stelle
126
Fork
48
Merge medio
4g 14h
PR unite (30g)
5

Descrizione

#### Problem description

When trying to profile a Gradle project build using the Java Pyroscope agent, the application name that is set in the `gradle.properties` file via the system property `-Dpyroscope.application.name `, is not recognized and is not applied. Instead of the custom name specified in the configuration, the automatically generated default name is displayed in the Pyroscope user interface.

#### Expected behavior:

It is expected that after the Gradle build is completed with the java agent configured, an application with the name `my-application` and the corresponding tags `{env=prod,version=1.0}`, as it was specified in `gradle.properties'.

#### Current (actual) behavior:

In the Pyroscope user interface, instead of the expected name `my-application`, an automatically generated name is displayed, in this case `javaspy.WeChRaEsRvWcEjq93mpGGg`. This indicates that the agent is running and sending data, but it cannot correctly determine or apply the application name from the JVM arguments passed to the Gradle daemon.

As you can see in the attached screenshot, there is no `my-application` in the list of applications.

#### Steps to reproduce

To reproduce the problem, follow these steps::

1. **Installing and configuring the Gradle environment:**
* Downloading the Gradle distribution:
```bash
wget https://services.gradle.org/distributions/gradle-8.14.2-bin.zip
```
* Creating a directory and unpacking an archive:
```bash
mkdir /opt/gradle
unzip -d /opt/gradle gradle-8.14.2-bin.zip
```
* Setting up the environment variable `PATH`:
```bash
export PATH=$PATH:/opt/gradle/gradle-8.14.2/bin
```

2. **Creating a Gradle test project:**
```bash
mkdir gradle-profiling-example
cd gradle-profiling-example
gradle init --type java-application --dsl kotlin --test-framework junit-jupiter --project-name simple-app --package com.example
```

3. **Loading the Java Pyroscope agent:**
* The agent is loaded into the Gradle daemon cache directory to be accessible to the daemon JVM.
```bash
wget -O /home/user/.gradle/daemon/8.14.2/pyroscope.jar https://github.com/grafana/pyroscope-java/releases/download/v2.1.2/pyroscope.jar
```
* *Note: The path is `/home/user/.gradle/daemon/8.14.2/` may vary depending on the user and the version of Gradle.*

4. **Launching the Pyroscope server:**
* A `docker-compose' file is created.yml` in the root of the project with the following contents:
```yaml
version: '3.8'
services:
pyroscope:
image: grafana/pyroscope:main-8c89229
ports:
- "4040:4040"
command:
- "server"
```
* The container starts:
```bash
docker-compose up -d
```

5. **Gradle configuration for profiling:**
* The `gradle.properties` file is created or edited in the root of the project with the following content, where the JVM arguments for the Gradle daemon are specified:
```properties
# JVM arguments for Gradle Daemon
org.gradle.jvmargs=-javaagent:pyroscope.jar -Dpyroscope.application.name=my-application{env=prod,version=1.0} -Dpyroscope.server.address=http://localhost:4040 -Dpyroscope.profile=cpu,alloc,lock,network,wall
```
* *Important: `pyroscope.jar` must be in a path accessible by the Gradle daemon. In this case, it was placed in his cache.*

6. **Launching the profiled build:**
* The project is being built. The '--no-daemon` flag is used to ensure that a new Gradle daemon is started that picks up arguments from `gradle.properties'.
```bash
gradle clean build --no-daemon
```

After completing these steps, when going to the Pyroscope web interface (`http://localhost:4040 `) the problem described above is observed.

![Image](https://github.com/user-attachments/assets/4b01eb75-5fd0-4b06-b748-fab6e4b2d6e8)

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Direzione di ricerca

Start with the gradle.properties configuration and the Java Pyroscope agent behavior when Gradle passes org.gradle.jvmargs to its daemon. Reproduce with gradle clean build --no-daemon and inspect the resulting application in the Pyroscope UI. Done means the build reports my-application with the env=prod and version=1.0 tags instead of an automatically generated name.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
java
Ambito
build-system, observability
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
42/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.